Test enumeratesigners
#346
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v22 help is not correct, it gives incorrect field names. They are correct in v23. Fix the v22 struct to match the correct names in v23.
`enumeratesigners` is implemented but not tested. Add a test and update the types table.
tcharding
reviewed
Aug 29, 2025
| use std::os::unix::fs::PermissionsExt; | ||
| std::fs::set_permissions(&script_path, std::fs::Permissions::from_mode(0o755)) | ||
| .expect("chmod"); | ||
| } |
There was a problem hiding this comment.
A few comments:
- This using tabs, can we use spaces please (tabs vs spaces is a age old religious war - I'm on team spaces).
- Line 18 has trailing whitespace
- Perhaps add a code comment saying "Script needs to be executable" or some such thing
- Perhaps a code comment on the
script_body- I have no idea why the script is as it is? - Its not clear to me what happens if this test is run on non-unix machine. I don't actually care about non-unix machines though, maybe put the
cfgon the whole test to make it clear we only support UNIX for this test.
tcharding
reviewed
Aug 29, 2025
| let node = Node::with_wallet(Wallet::None, &[&signer_arg]); | ||
| let json: EnumerateSigners = node.client.enumerate_signers().expect("enumeratesigners"); | ||
|
|
||
| assert_eq!(json.signers[0].fingerprint, "deadbeef"); |
There was a problem hiding this comment.
As in other comment, better to use first than the array access. In idiomatic Rust array access is only used if there is a good reason to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enumeratesignersis implemented but not tested. Also the v22 help is not correct, it gives incorrect field names which were implemented in the struct. They are correct in v23 and onwards help.